Discussion:
I've committed my first revision (r39333). Expect a plague of locusts ;)
(too old to reply)
John McCabe-Dansted
2011-07-17 12:47:07 UTC
Permalink
I have finally exercised my commit privileges by committing r39333. I
spent an hours checking everything is OK, but this is my first commit
ever to a shared VCS... so expect a rain of fire.

Also, is this OK for branch? Should I commit there as well?

If so, to do that I just check out branch, reapply the patch and do an
"svn ci" again? The LyX project doesn't use any special magic to
backport patches?


------------------------------------------------------------------------
r39333 | cmd | 2011-07-17 20:32:00 +0800 (Sun, 17 Jul 2011) | 3 lines

Fix bug #7467: build failure on GNU/Hurd, which doesn't define PATH_MAX.
(Patch from Pino, adapted for trunk by Sven)

http://www.lyx.org/trac/changeset/39333
--
John C. McCabe-Dansted
Pavel Sanda
2011-07-17 20:00:58 UTC
Permalink
Post by John McCabe-Dansted
I have finally exercised my commit privileges by committing r39333. I
spent an hours checking everything is OK, but this is my first commit
ever to a shared VCS... so expect a rain of fire.
everything seems fine.
Post by John McCabe-Dansted
Also, is this OK for branch? Should I commit there as well?
for any commit to branch (except to documentation) you need explicit
OK from branch maintainer, ie Richard.
Post by John McCabe-Dansted
If so, to do that I just check out branch, reapply the patch and do an
"svn ci" again? The LyX project doesn't use any special magic to
backport patches?
it can be slightly easier with git if the code is the same.
but you need to add entry to file status.20x.

last but not least, welcome on the ship!

pavel
Richard Heck
2011-07-18 13:43:38 UTC
Permalink
Post by Pavel Sanda
Post by John McCabe-Dansted
Also, is this OK for branch? Should I commit there as well?
for any commit to branch (except to documentation) you need explicit
OK from branch maintainer, ie Richard.
And the usual method is to reply to the commit message, which sends it
to lyx-devel, with a question of the form: OK for branch?

In this case, I know nothing about this, so if it seems safe to you,
please go ahead and commit to branch.

Richard
Uwe Stöhr
2011-07-19 01:32:41 UTC
Permalink
Post by John McCabe-Dansted
I have finally exercised my commit privileges by committing r39333.
Welcome on board!

regards Uwe

Loading...