Stephan Witt
2011-01-03 12:03:10 UTC
Author: vfr
Date: Mon Jan 3 12:42:01 2011
New Revision: 37068
URL: http://www.lyx.org/trac/changeset/37068
Remove GuiToolbar::allowauto_ and define this property in the Toolbars.h::Visibility enum.
Now, there is the bug that autoallow is incorrectly set to true when visibility_ has the Visibility::SAMEROW flag. One shouldn't use >= on an enum (GuiToolbar::setVisibility), as newly added items will exhibit unexpected behaviour.
lyx-devel/trunk/src/frontends/qt4/GuiToolbar.cpp
lyx-devel/trunk/src/frontends/qt4/GuiToolbar.h
lyx-devel/trunk/src/frontends/qt4/Toolbars.h
Ok, thanks.Date: Mon Jan 3 12:42:01 2011
New Revision: 37068
URL: http://www.lyx.org/trac/changeset/37068
Remove GuiToolbar::allowauto_ and define this property in the Toolbars.h::Visibility enum.
Now, there is the bug that autoallow is incorrectly set to true when visibility_ has the Visibility::SAMEROW flag. One shouldn't use >= on an enum (GuiToolbar::setVisibility), as newly added items will exhibit unexpected behaviour.
lyx-devel/trunk/src/frontends/qt4/GuiToolbar.cpp
lyx-devel/trunk/src/frontends/qt4/GuiToolbar.h
lyx-devel/trunk/src/frontends/qt4/Toolbars.h
Now I have the following reduced patch left. Ok to apply?
Stephan