[Patch] Cleanup patch that fixes #7375 (spellchecker gui)

[Abdelrazak Younes]

Hi Pavel,

Here is a patch that should fixes #7375. The patch is big but this is
mostly mechanical changes needed for a proper Dock widget and code
shuffling:

* Transform Spellchecker.ui into a simple QWidget
* Pimpl all we can
* Remove Close button (as for all other dock widgets)
* Make the dialog buffer independent (as for all other dock widgets)

Please give this patch a try and tell me if it's OK to commit. There are
still quite some bugs for this dialog that I will try to address afterwards.

Abdel.

[Pavel Sanda]

Post by Abdelrazak Younes
Please give this patch a try and tell me if it's OK to commit. There are
still quite some bugs for this dialog that I will try to address afterwards.

thy still overlap into each other when window size is small (in fact normal).
pavel

[Abdelrazak Younes]

Post by Pavel Sanda

Post by Abdelrazak Younes
Please give this patch a try and tell me if it's OK to commit. There are
still quite some bugs for this dialog that I will try to address afterwards.

thy still overlap into each other when window size is small (in fact normal).

Yes, this is normal and due to the minimum height of the two widgets.
But I cannot figure out how you get the two widget on top of each other.
On my Windows system with Qr4.7 the 2 dock widgets are arranged in tabs
automatically...
So the fix would be to force this behaviour on all platforms I guess.

Abdel.

[Pavel Sanda]

Yes, this is normal and due to the minimum height of the two widgets. But I
cannot figure out how you get the two widget on top of each other. On my
Windows system with Qr4.7 the 2 dock widgets are arranged in tabs
automatically...
So the fix would be to force this behaviour on all platforms I guess.

maybe its a matter of having qt 4.6 here.
pavel

[Abdelrazak Younes]

Post by Pavel Sanda

Yes, this is normal and due to the minimum height of the two widgets. But I
cannot figure out how you get the two widget on top of each other. On my
Windows system with Qr4.7 the 2 dock widgets are arranged in tabs
automatically...
So the fix would be to force this behaviour on all platforms I guess.

maybe its a matter of having qt 4.6 here.

I doubt it. Tabbed dock widget is quite an old Qt feature IIRC.

Anyway, as I said this dialog really need some love... I can give it
some now, do you want it?

Abdel.