Discussion:
r37132 - lyx-devel/branches/BRANCH_1_6_X/development/cmake/src
(too old to reply)
Kornel
2011-01-06 19:07:47 UTC
Permalink
That's, what I don't like much. Too many people define the tab value
different.
Kornel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are
used.
Peter
Mixing is a consequence having tab stop != indent.

Kornel
Kornel
2011-01-06 18:27:17 UTC
Permalink
cmake: use tabs
That's, what I don't like much. Too many people define the tab value different.

Kornel
Stephan Witt
2011-01-06 18:35:33 UTC
Permalink
Post by Kornel
cmake: use tabs
That's, what I don't like much. Too many people define the tab value different.
For leading tabs any value results in perfectly aligned rows.
So, I don't understand your concerns. The problem is the
mixing of tab and spaces at line begin.

Stephan
Kornel
2011-01-06 19:06:16 UTC
Permalink
Post by Stephan Witt
Post by Kornel
cmake: use tabs
That's, what I don't like much. Too many people define the tab value different.
For leading tabs any value results in perfectly aligned rows.
So, I don't understand your concerns. The problem is the
mixing of tab and spaces at line begin.
Stephan
You would, if you would have tab defined to be at 8 stop.

Kornel
Peter Kuemmel
2011-01-06 18:51:09 UTC
Permalink
-------- Original-Nachricht --------
Datum: Thu, 6 Jan 2011 19:27:17 +0100
Betreff: Re: r37132 - lyx-devel/branches/BRANCH_1_6_X/development/cmake/src
cmake: use tabs
That's, what I don't like much. Too many people define the tab value different.
Kornel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.

Peter
--
NEU: FreePhone - kostenlos mobil telefonieren und surfen!
Jetzt informieren: http://www.gmx.net/de/go/freephone
Peter Kuemmel
2011-01-06 20:15:02 UTC
Permalink
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?

Peter
--
NEU: FreePhone - kostenlos mobil telefonieren und surfen!
Jetzt informieren: http://www.gmx.net/de/go/freephone
Kornel
2011-01-07 07:00:20 UTC
Permalink
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Peter
2 is my favour. Thanks.

Kornel
Stephan Witt
2011-01-07 08:15:18 UTC
Permalink
Post by Kornel
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Peter
2 is my favour. Thanks.
Just my 2 cents...

What's the difference to using tabs with "tab stop" and "indent" == 2?
I'm aware only of the viewing of diffs on terminal.

Stephan
Kornel
2011-01-07 08:51:32 UTC
Permalink
Post by Stephan Witt
Post by Kornel
Post by Peter Kuemmel
Post by Kornel
But ATMit is mixed in the cmake files, and in lyx's code also tabs
are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Peter
2 is my favour. Thanks.
Just my 2 cents...
What's the difference to using tabs with "tab stop" and "indent" == 2?
I'm aware only of the viewing of diffs on terminal.
Stephan
Nothing, if it were only this project.
(Don't know, if printed documents respects the "tab stop" == 2, or if they will be converted first ...)

Kornel
Stephan Witt
2011-01-07 09:10:06 UTC
Permalink
Post by Kornel
Post by Stephan Witt
Post by Kornel
Post by Peter Kuemmel
Post by Kornel
But ATMit is mixed in the cmake files, and in lyx's code also tabs
are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Peter
2 is my favour. Thanks.
Just my 2 cents...
What's the difference to using tabs with "tab stop" and "indent" == 2?
I'm aware only of the viewing of diffs on terminal.
Stephan
Nothing, if it were only this project.
Working on different projects is an argument for using tabs instead of spaces.
With tabs you are able to have consistent indentation regardless of the projects
indentation width preferences.

And I believe most people have more then one project :-)
Post by Kornel
(Don't know, if printed documents respects the "tab stop" == 2, or if they will be converted first ...)
Printed?
Try --tabsize=2 with a2ps e.g.

Stephan
Abdelrazak Younes
2011-01-07 08:19:04 UTC
Permalink
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Come on. I use the same editor to edit CMakeList and the C++ source
(QtCreator or MSVC). Please just one style i.e. tab only.

Abdel.
Kornel
2011-01-07 08:47:50 UTC
Permalink
Post by Abdelrazak Younes
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Come on. I use the same editor to edit CMakeList and the C++ source
(QtCreator or MSVC). Please just one style i.e. tab only.
Abdel.
Abdel, we all are in more than one project involved. Each one defines the tab stop differently.
This is a mess, if using the same editor. There are no such problems using blanks.

Kornel
Peter Kümmel
2011-01-07 09:42:36 UTC
Permalink
Post by Abdelrazak Younes
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Come on. I use the same editor to edit CMakeList and the C++ source
(QtCreator or MSVC). Please just one style i.e. tab only.
I also realized after my last mail and adding non C++ files to Studio
(I assume we could add them also in other IDEs), that having C++ files
with tabs and non-C++ files with spaces makes no sense. Sorry Kornel,
but LyX is a tab-project, and changing this provokes religious like
flame-wars. So I think we should use tabs also in the cmake files.

"But in the README/INSTALL files we use spaces" you may object, but
these files are not used for the development like C++ and cmake files.

I don't know how often you touch C++ files but editing them frequently
you will also see that one style for all files is better.

Peter
Kornel
2011-01-07 10:28:18 UTC
Permalink
Post by Peter Kümmel
Post by Abdelrazak Younes
Post by Peter Kuemmel
Post by Kornel
Post by Peter Kuemmel
But ATMit is mixed in the cmake files, and in lyx's code also tabs are used.
Peter
Mixing is a consequence having tab stop != indent.
Kornel
I've no problem switching to spaces. Do you prefer 2,3, or 4?
Come on. I use the same editor to edit CMakeList and the C++ source
(QtCreator or MSVC). Please just one style i.e. tab only.
I also realized after my last mail and adding non C++ files to Studio
(I assume we could add them also in other IDEs), that having C++ files
with tabs and non-C++ files with spaces makes no sense. Sorry Kornel,
but LyX is a tab-project, and changing this provokes religious like
flame-wars. So I think we should use tabs also in the cmake files.
I give up. But concerning tab versus spaces in branch it is not sooo unambiguous :
# (line starts with blank)
# find . -name \*.cpp | xargs egrep '^ ' | wc
-> 12825 71143 873222

# (line starting with tab)
# find . -name \*.cpp | xargs egrep '^ ' | wc
-> 99374 469889 5878942
Post by Peter Kümmel
"But in the README/INSTALL files we use spaces" you may object, but
these files are not used for the development like C++ and cmake files.
I don't know how often you touch C++ files but editing them frequently
you will also see that one style for all files is better.
Peter
Of course it is. I remember having this discussion in the past. At that time I was not actively involved.
But I am unable to find the relevant mails :(

Kornel

Loading...